Skip to content

API/TST: make hasnans always return python booleans #23349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2018
Merged

API/TST: make hasnans always return python booleans #23349

merged 2 commits into from
Oct 27, 2018

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 commented Oct 26, 2018 •
edited
Loading

Index.hasnans currently returns either a python or a numpy boolean, depending on circumstances. This PR ensures that only python booleans ae returned and makes the tests for hasnans stricter.

@jreback jreback added the Dtype Conversions Unexpected or buggy dtype conversions label Oct 26, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 26, 2018
@jreback
Copy link
Contributor

jreback commented Oct 26, 2018

lgtm ping on green

@jorisvandenbossche
Copy link
Member

It's failing for Series.hasnans, which still returns a numpy bool

@topper-123 topper-123 force-pushed the hasnans_always_python_bool branch from 831501b to aa0fa5a Compare October 26, 2018 17:09
@pep8speaks
Copy link

Hello @topper-123! Thanks for updating the PR.

@topper-123 topper-123 force-pushed the hasnans_always_python_bool branch from aa0fa5a to 031e5f7 Compare October 26, 2018 17:47
@codecov
Copy link

codecov bot commented Oct 26, 2018

Codecov Report

Merging #23349 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23349   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         169      169           
  Lines       51261    51261           
=======================================
  Hits        47277    47277           
  Misses       3984     3984
Flag Coverage Δ
#multiple 90.66% <100%> (ø) ⬆️
#single 42.23% <66.66%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/datetimelike.py 93.21% <100%> (ø) ⬆️
pandas/core/base.py 97.61% <100%> (ø) ⬆️
pandas/core/indexes/base.py 96.61% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caea25a...031e5f7. Read the comment docs.

@topper-123
Copy link
Contributor Author

All green now.

@jschendel jschendel merged commit 051f4a2 into pandas-dev:master Oct 27, 2018
@topper-123 topper-123 deleted the hasnans_always_python_bool branch October 27, 2018 15:54
thoo added a commit to thoo/pandas that referenced this pull request Oct 27, 2018
@thoo
Merge remote-tracking branch 'repo_org/master' into check_np_pd_fromE…
d824414 
…xamples

* repo_org/master:
  DOC: Validate that See Also section items do not contain the pandas. prefix (pandas-dev#23145)
  API/TST: make hasnans always return python booleans (pandas-dev#23349)
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@topper-123 @tm9k1
API/TST: make hasnans always return python booleans (pandas-dev#23349)
3b6310a
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@topper-123 @Pingviinituutti
API/TST: make hasnans always return python booleans (pandas-dev#23349)
926533e
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@topper-123 @Pingviinituutti
API/TST: make hasnans always return python booleans (pandas-dev#23349)
b3728c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

@jschendel jschendel jschendel approved these changes

Assignees
No one assigned
Labels
Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@topper-123 @jreback @jorisvandenbossche @pep8speaks @jschendel